Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-6591

some issue processing \uFFFF in query string in our binary packages [was: garbage chars in query string when Looking up doc via UI ]

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: build
    • Security Level: Public
    • Labels:
      None
    • Environment:
      build-1705

      Description

      Using the UI, created a document with the string "simple" as id

      Then in the UI where there's the documents section of the bucket, type simple into the <document id> field, and this query is ran:
      http://10.3.3.62:8091/couchBase/default/_all_docs?startkey=%22simple%22&endkey=%22simple%EF%BF%BF%22&skip=0&include_docs=true&limit=6&_=1347310276137

      Lookup fails because of these extra chars in the query in the endkey there: %EF%BF%BF

      If I click to Lookup Id, the document is retrieved as the query this time is:
      http://10.3.3.62:8091/couchBase/default/simple?_=1347310297868

      perhaps we should use the same method for both lookups.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          thuan Thuan Nguyen added a comment -

          Integrated in github-couchdb-preview #516 (See http://qa.hq.northscale.net/job/github-couchdb-preview/516/)
          MB-6591: Use raw collation for _all_docs query params (Revision fd03c3a583904440d34bbc8033a826cbec446357)

          Result = SUCCESS
          Farshid Ghods :
          Files :

          • src/couchdb/couch_httpd_view.erl
          • src/couch_index_merger/src/couch_view_merger.erl
          • src/couchdb/couch_httpd_db.erl
          • share/www/script/test/view_collation_raw.js
          • src/couchdb/couch_btree.erl
          • share/www/script/test/all_docs.js
          Show
          thuan Thuan Nguyen added a comment - Integrated in github-couchdb-preview #516 (See http://qa.hq.northscale.net/job/github-couchdb-preview/516/ ) MB-6591 : Use raw collation for _all_docs query params (Revision fd03c3a583904440d34bbc8033a826cbec446357) Result = SUCCESS Farshid Ghods : Files : src/couchdb/couch_httpd_view.erl src/couch_index_merger/src/couch_view_merger.erl src/couchdb/couch_httpd_db.erl share/www/script/test/view_collation_raw.js src/couchdb/couch_btree.erl share/www/script/test/all_docs.js
          Hide
          vmx Volker Mische added a comment - - edited

          The problem from the second comment [1] is fixed. You won't get an error if you do a
          curl "http://10.3.3.62:8091/couchBase/default/_all_docs?startkey=%22simple%22&endkey=%22simple%EF%BF%BF%22&skip=0&include_docs=true&limit=6"

          Though I think we still might have the problem with the \uFFFF, as the queries are on _all_docs and _all_docs uses raw collation. Please check whether \uFFFF really returns the expected range or not. If it doesn't work a high byte value might help, like e.g. %7F

          [1] http://www.couchbase.com/issues/browse/MB-6591?focusedCommentId=38353&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-38353

          Show
          vmx Volker Mische added a comment - - edited The problem from the second comment [1] is fixed. You won't get an error if you do a curl "http://10.3.3.62:8091/couchBase/default/_all_docs?startkey=%22simple%22&endkey=%22simple%EF%BF%BF%22&skip=0&include_docs=true&limit=6" Though I think we still might have the problem with the \uFFFF, as the queries are on _all_docs and _all_docs uses raw collation. Please check whether \uFFFF really returns the expected range or not. If it doesn't work a high byte value might help, like e.g. %7F [1] http://www.couchbase.com/issues/browse/MB-6591?focusedCommentId=38353&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-38353
          Hide
          thuan Thuan Nguyen added a comment -

          Integrated in single-node-2.0.x-windows7-64-view #18 (See http://qa.hq.northscale.net/job/single-node-2.0.x-windows7-64-view/18/)
          MB-6591: Test cases to make sure the fix is valid (Revision 8535782ee0ffe7305ebbf3dc00df530b2350edf0)

          Result = UNSTABLE
          IrynaM :
          Files :

          • conf/py-viewquery.conf
          • pytests/viewtests.py
          Show
          thuan Thuan Nguyen added a comment - Integrated in single-node-2.0.x-windows7-64-view #18 (See http://qa.hq.northscale.net/job/single-node-2.0.x-windows7-64-view/18/ ) MB-6591 : Test cases to make sure the fix is valid (Revision 8535782ee0ffe7305ebbf3dc00df530b2350edf0) Result = UNSTABLE IrynaM : Files : conf/py-viewquery.conf pytests/viewtests.py
          Hide
          thuan Thuan Nguyen added a comment -

          Integrated in multi-nodes-windows-64-viewtest #20 (See http://qa.hq.northscale.net/job/multi-nodes-windows-64-viewtest/20/)
          MB-6591: Test cases to make sure the fix is valid (Revision 8535782ee0ffe7305ebbf3dc00df530b2350edf0)

          Result = SUCCESS
          IrynaM :
          Files :

          • conf/py-viewquery.conf
          • pytests/viewtests.py
          Show
          thuan Thuan Nguyen added a comment - Integrated in multi-nodes-windows-64-viewtest #20 (See http://qa.hq.northscale.net/job/multi-nodes-windows-64-viewtest/20/ ) MB-6591 : Test cases to make sure the fix is valid (Revision 8535782ee0ffe7305ebbf3dc00df530b2350edf0) Result = SUCCESS IrynaM : Files : conf/py-viewquery.conf pytests/viewtests.py
          Hide
          iryna iryna added a comment -

          verified build-1884

          Show
          iryna iryna added a comment - verified build-1884

            People

            • Assignee:
              iryna iryna
              Reporter:
              tommie Tommie McAfee
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes