Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-7190

'timings' statistics not consistent between 1.8.1 and 2.0

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: couchbase-bucket
    • Security Level: Public
    • Labels:

      Description

      I no longer see the same timing stats on 2.0 that we had on 1.8. One major one that is missing is the "store_cmd", but I can't tell if others are missing as well.

      Additionally, one a customer's system, I see this output before the actual timings:
      [root@AMIR-DB-SSD-1 ~]# /opt/couchbase/bin/cbstats localhost:11210 timings
      sec_label(2)
      sec_label(4)
      sec_label(4)
      sec_label(8)
      sec_label(8)
      sec_label(16)
      sec_label(16)
      sec_label(32)
      sec_label(32)
      sec_label(64)
      sec_label(64)
      sec_label(128)
      sec_label(128)
      sec_label(256)
      sec_label(256)
      sec_label(512)
      sec_label(512)
      sec_label(1024)
      sec_label(1024)
      sec_label(2048)
      sec_label(2048)
      sec_label(4096)

      I consider this a pretty big blocker since the timing stats have proven very useful in diagnostics. If they've moved somewhere, please advise.

        Issue Links

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          chiyoung Chiyoung Seo added a comment -

          Mike, STORE timing was deleted by accident in 2.0. Please add it back to 2.0.

          Show
          chiyoung Chiyoung Seo added a comment - Mike, STORE timing was deleted by accident in 2.0. Please add it back to 2.0.
          Hide
          steve Steve Yen added a comment -

          up to blocker by bug-scrub

          Show
          steve Steve Yen added a comment - up to blocker by bug-scrub
          Hide
          thuan Thuan Nguyen added a comment -

          Integrated in github-ep-engine-2-0 #460 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/460/)
          MB-7190: Add back store cmd timings (Revision 9b8377b94356c867cab2f63b2b5798001ca671f7)

          Result = SUCCESS
          Mike Wiederhold :
          Files :

          • src/ep_engine.cc
          • src/stats.hh
          • management/cbstats
          Show
          thuan Thuan Nguyen added a comment - Integrated in github-ep-engine-2-0 #460 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/460/ ) MB-7190 : Add back store cmd timings (Revision 9b8377b94356c867cab2f63b2b5798001ca671f7) Result = SUCCESS Mike Wiederhold : Files : src/ep_engine.cc src/stats.hh management/cbstats
          Show
          steve Steve Yen added a comment - http://review.couchbase.org/#/c/22570/3
          Hide
          perry Perry Krug added a comment -

          Is it just store that was removed? I can't confirm whether others are missing as well...could we have a general pass at it?

          Also, what about the odd messages that were displayed:
          [root@AMIR-DB-SSD-1 ~]# /opt/couchbase/bin/cbstats localhost:11210 timings
          sec_label(2)
          sec_label(4)
          sec_label(4)
          sec_label(8)
          sec_label(8)
          sec_label(16)
          sec_label(16)
          sec_label(32)
          sec_label(32)
          sec_label(64)
          sec_label(64)
          sec_label(128)
          sec_label(128)
          sec_label(256)
          sec_label(256)
          sec_label(512)
          sec_label(512)
          sec_label(1024)
          sec_label(1024)
          sec_label(2048)
          sec_label(2048)
          sec_label(4096)

          Show
          perry Perry Krug added a comment - Is it just store that was removed? I can't confirm whether others are missing as well...could we have a general pass at it? Also, what about the odd messages that were displayed: [root@AMIR-DB-SSD-1 ~] # /opt/couchbase/bin/cbstats localhost:11210 timings sec_label(2) sec_label(4) sec_label(4) sec_label(8) sec_label(8) sec_label(16) sec_label(16) sec_label(32) sec_label(32) sec_label(64) sec_label(64) sec_label(128) sec_label(128) sec_label(256) sec_label(256) sec_label(512) sec_label(512) sec_label(1024) sec_label(1024) sec_label(2048) sec_label(2048) sec_label(4096)
          Hide
          mikew Mike Wiederhold added a comment - - edited

          Yes, only store. The others were sqlite specific. And I removed all of those extra messages.

          Show
          mikew Mike Wiederhold added a comment - - edited Yes, only store. The others were sqlite specific. And I removed all of those extra messages.
          Hide
          dhaikney David Haikney added a comment -

          Closing as part of supportability scrub. This issue is no longer present.

          Show
          dhaikney David Haikney added a comment - Closing as part of supportability scrub. This issue is no longer present.

            People

            • Assignee:
              mikew Mike Wiederhold
              Reporter:
              perry Perry Krug
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes