Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-7360

moxi crashes when doing a mget with a key size exceeding 250 characters

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Cannot Reproduce
    • Affects Version/s: 1.8.0, 1.8.1, 2.0
    • Fix Version/s: 2.1.0
    • Component/s: moxi
    • Security Level: Public
    • Labels:
    • Environment:
      1.8.1 Couchbase using the ASCII/Memcache protocol , node js
    • Sprint:
      PCI Team - Sprint 2
    No reviews matched the request. Check your Options in the drop-down menu of this sections header.

      Activity

      Hide
      balak balak added a comment -

      // Multi-key GET/GETS.
      > //
      > // We should keep processing for a non-quiet
      > // terminating response (NO-OP).
      > //
      > conn_set_state(c, conn_new_cmd);
      >
      > if (status != 0) {
      > assert(it == NULL);
      >
      > if (status == PROTOCOL_BINARY_RESPONSE_KEY_ENOENT)

      { > return; // Swallow miss response. > }


      >
      > // TODO: Handle error case. Should we pause the conn
      > // or keep looking for more responses?
      > //
      > assert(false); // <--- THIS IS LINE 774, REFERRED ON THE ERROR MESSAGE :GFERNANDEZ
      > return;
      > }
      >

      Show
      balak balak added a comment - // Multi-key GET/GETS. > // > // We should keep processing for a non-quiet > // terminating response (NO-OP). > // > conn_set_state(c, conn_new_cmd); > > if (status != 0) { > assert(it == NULL); > > if (status == PROTOCOL_BINARY_RESPONSE_KEY_ENOENT) { > return; // Swallow miss response. > } > > // TODO: Handle error case. Should we pause the conn > // or keep looking for more responses? > // > assert(false); // <--- THIS IS LINE 774, REFERRED ON THE ERROR MESSAGE :GFERNANDEZ > return; > } >
      Hide
      steve Steve Yen added a comment -

      Hi Ronnie,
      Got a C fix for you. Can you take a look at a moxi fix?
      Thanks,
      Steve

      Show
      steve Steve Yen added a comment - Hi Ronnie, Got a C fix for you. Can you take a look at a moxi fix? Thanks, Steve
      Hide
      farshid Farshid Ghods (Inactive) added a comment -

      per bug scrub -

      deferring this to 2.0.2

      Show
      farshid Farshid Ghods (Inactive) added a comment - per bug scrub - deferring this to 2.0.2
      Hide
      ronnie Ronnie Sun (Inactive) added a comment -

      Tried with 2.0.1 build and the latest moxi checkout. Cannot reproduce this issue.

      Investigations as follows:

      • When issuing an ascii multiget command by supplying a single invalid key (key_len > 250), moxi simply returned an 'END'
      • When issuing an ascii multiget command by supplying a mixed of valid and invalid keys, moxi returned results for valid ones and bypassed the invalids. (Actually the binary downstream returned NOOP for these invalid keys, moxi then released the connection resources.)
      • Tried 10000 ops, moxi did not crash.

      Command used:

      MemcachedAsciiClient.getMulti(["aaa","abcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghiabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijj", "bbb"])

      Show
      ronnie Ronnie Sun (Inactive) added a comment - Tried with 2.0.1 build and the latest moxi checkout. Cannot reproduce this issue. Investigations as follows: When issuing an ascii multiget command by supplying a single invalid key (key_len > 250), moxi simply returned an 'END' When issuing an ascii multiget command by supplying a mixed of valid and invalid keys, moxi returned results for valid ones and bypassed the invalids. (Actually the binary downstream returned NOOP for these invalid keys, moxi then released the connection resources.) Tried 10000 ops, moxi did not crash. Command used: MemcachedAsciiClient.getMulti( ["aaa","abcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghiabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijj", "bbb"] )
      Hide
      maria Maria McDuff (Inactive) added a comment -

      abhinav, pls check if this is still happening in current 2.0.2 build. close if no longer an issue. thanks.

      Show
      maria Maria McDuff (Inactive) added a comment - abhinav, pls check if this is still happening in current 2.0.2 build. close if no longer an issue. thanks.
      Hide
      maria Maria McDuff (Inactive) added a comment -

      unable to repro the crash.
      closing as fixed.

      Show
      maria Maria McDuff (Inactive) added a comment - unable to repro the crash. closing as fixed.

        People

        • Assignee:
          abhinav Abhinav Dangeti
          Reporter:
          balak balak
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Agile

              Gerrit Reviews

              There are no open Gerrit changes