Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Incomplete
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.1.0
    • Component/s: ns_server
    • Security Level: Public
    • Labels:
      None

      Description

      This is being repeated every 30 seconds in the logs:

      [ns_server:debug,2013-04-16T10:42:07.538,ns_1@10.105.22.156:compaction_daemon<0.6708.0>:compaction_daemon:handle_info:399]Starting compaction for the following buckets:
      [<<"testing">>,<<"default">>]
      [ns_server:info,2013-04-16T10:42:07.538,ns_1@10.105.22.156:<0.2781.70>:compaction_daemon:try_to_cleanup_indexes:604]Cleaning up indexes for bucket `testing`
      [ns_server:info,2013-04-16T10:42:07.538,ns_1@10.105.22.156:<0.2781.70>:compaction_daemon:spawn_bucket_compactor:563]Compacting bucket testing with config:
      [{database_fragmentation_threshold,{30,undefined}},
      {view_fragmentation_threshold,{30,undefined}}]
      [ns_server:debug,2013-04-16T10:42:07.538,ns_1@10.105.22.156:<0.2784.70>:compaction_daemon:bucket_needs_compaction:966]`testing` data size is 95325, disk size is 8443950
      [ns_server:info,2013-04-16T10:42:07.554,ns_1@10.105.22.156:<0.2785.70>:compaction_daemon:try_to_cleanup_indexes:604]Cleaning up indexes for bucket `default`
      [ns_server:info,2013-04-16T10:42:07.554,ns_1@10.105.22.156:<0.2785.70>:compaction_daemon:spawn_bucket_compactor:563]Compacting bucket default with config:
      [{database_fragmentation_threshold,{30,undefined}},
      {view_fragmentation_threshold,{30,undefined}}]
      [ns_server:debug,2013-04-16T10:42:07.554,ns_1@10.105.22.156:<0.2788.70>:compaction_daemon:bucket_needs_compaction:966]`default` data size is 3472892, disk size is 30523027
      [ns_server:debug,2013-04-16T10:42:07.554,ns_1@10.105.22.156:<0.2790.70>:compaction_daemon:view_needs_compaction:1123]`default/_design/dev_allbets/main` data_size is 0, disk_size is 13077
      [ns_server:debug,2013-04-16T10:42:07.554,ns_1@10.105.22.156:compaction_daemon<0.6708.0>:compaction_daemon:handle_info:457]Finished compaction iteration.
      [ns_server:debug,2013-04-16T10:42:07.554,ns_1@10.105.22.156:compaction_daemon<0.6708.0>:compaction_daemon:schedule_next_compaction:1442]Finished compaction too soon. Next run will be in 30s

      Aside from fixing this constantly running compaction, we should also be implementing a bit of logic that looks at how much data will actually be saved. 30% of 400mb is only 120mb...that's not really going to save much disk.

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        perry Perry Krug added a comment -

        I tried reproducing this on my machine, and even when setting the threshold to 10GB for views and data files, the compaction still tries to run every 30 seconds:
        [ns_server:debug,2013-04-10T20:50:02.475,ns_1@127.0.0.1:compaction_daemon<0.4766.1>:compaction_daemon:handle_info:399]Starting compaction for the following buckets:
        [<<"gamesim-sample">>,<<"beer-sample">>,<<"default">>]
        [ns_server:info,2013-04-10T20:50:02.475,ns_1@127.0.0.1:<0.20205.162>:compaction_daemon:try_to_cleanup_indexes:602]Cleaning up indexes for bucket `gamesim-sample`
        [ns_server:info,2013-04-10T20:50:02.478,ns_1@127.0.0.1:<0.20205.162>:compaction_daemon:spawn_bucket_compactor:561]Compacting bucket gamesim-sample with config:
        [

        {parallel_db_and_view_compaction,false},
        {database_fragmentation_threshold,{undefined,10737418240}},
        {view_fragmentation_threshold,{undefined,10737418240}}]
        [ns_server:debug,2013-04-10T20:50:02.479,ns_1@127.0.0.1:<0.20208.162>:compaction_daemon:bucket_needs_compaction:964]`gamesim-sample` data size is 905949, disk size is 996135
        [ns_server:debug,2013-04-10T20:50:02.479,ns_1@127.0.0.1:<0.20210.162>:compaction_daemon:view_needs_compaction:1121]`gamesim-sample/_design/players/main` data_size is 3573, disk_size is 53435
        [ns_server:debug,2013-04-10T20:50:02.480,ns_1@127.0.0.1:<0.20211.162>:compaction_daemon:view_needs_compaction:1121]`gamesim-sample/_design/players/replica` data_size is 0, disk_size is 4165
        [ns_server:debug,2013-04-10T20:50:02.480,ns_1@127.0.0.1:<0.20213.162>:compaction_daemon:view_needs_compaction:1121]`gamesim-sample/_design/dev_test/main` data_size is 37335, disk_size is 49316
        [ns_server:debug,2013-04-10T20:50:02.480,ns_1@127.0.0.1:<0.20214.162>:compaction_daemon:view_needs_compaction:1121]`gamesim-sample/_design/dev_test/replica` data_size is 0, disk_size is 4163
        [ns_server:debug,2013-04-10T20:50:02.481,ns_1@127.0.0.1:<0.20216.162>:compaction_daemon:view_needs_compaction:1121]`gamesim-sample/_design/dev_players/main` data_size is 3573, disk_size is 53435
        [ns_server:debug,2013-04-10T20:50:02.481,ns_1@127.0.0.1:<0.20217.162>:compaction_daemon:view_needs_compaction:1121]`gamesim-sample/_design/dev_players/replica` data_size is 0, disk_size is 4165
        [ns_server:info,2013-04-10T20:50:02.481,ns_1@127.0.0.1:<0.20218.162>:compaction_daemon:try_to_cleanup_indexes:602]Cleaning up indexes for bucket `beer-sample`
        [ns_server:info,2013-04-10T20:50:02.484,ns_1@127.0.0.1:<0.20218.162>:compaction_daemon:spawn_bucket_compactor:561]Compacting bucket beer-sample with config:
        [{parallel_db_and_view_compaction,false}

        ,
        {database_fragmentation_threshold,{undefined,10737418240}},
        {view_fragmentation_threshold,{undefined,10737418240}}]
        [ns_server:debug,2013-04-10T20:50:02.484,ns_1@127.0.0.1:<0.20221.162>:compaction_daemon:bucket_needs_compaction:964]`beer-sample` data size is 1430, disk size is 70079
        [ns_server:debug,2013-04-10T20:50:02.484,ns_1@127.0.0.1:<0.20223.162>:compaction_daemon:view_needs_compaction:1121]`beer-sample/_design/beer/main` data_size is 0, disk_size is 28770
        [ns_server:debug,2013-04-10T20:50:02.485,ns_1@127.0.0.1:<0.20224.162>:compaction_daemon:view_needs_compaction:1121]`beer-sample/_design/beer/replica` data_size is 0, disk_size is 4165
        [ns_server:info,2013-04-10T20:50:02.485,ns_1@127.0.0.1:<0.20225.162>:compaction_daemon:try_to_cleanup_indexes:602]Cleaning up indexes for bucket `default`
        [ns_server:info,2013-04-10T20:50:02.485,ns_1@127.0.0.1:<0.20225.162>:compaction_daemon:spawn_bucket_compactor:561]Compacting bucket default with config:
        [

        {parallel_db_and_view_compaction,false},
        {database_fragmentation_threshold,{undefined,10737418240}},
        {view_fragmentation_threshold,{undefined,10737418240}}]
        [ns_server:debug,2013-04-10T20:50:02.486,ns_1@127.0.0.1:<0.20228.162>:compaction_daemon:bucket_needs_compaction:964]`default` data size is 748764, disk size is 787194
        [ns_server:debug,2013-04-10T20:50:02.486,ns_1@127.0.0.1:compaction_daemon<0.4766.1>:compaction_daemon:handle_info:457]Finished compaction iteration.
        [ns_server:debug,2013-04-10T20:50:02.486,ns_1@127.0.0.1:compaction_daemon<0.4766.1>:compaction_daemon:schedule_next_compaction:1441]Finished compaction too soon. Next run will be in 30s

        And trying to turn it off altogether by unchecking all boxes:
        [ns_server:debug,2013-04-10T20:52:32.526,ns_1@127.0.0.1:compaction_daemon<0.4766.1>:compaction_daemon:handle_info:399]Starting compaction for the following buckets:
        [<<"gamesim-sample">>,<<"beer-sample">>,<<"default">>]
        [ns_server:info,2013-04-10T20:52:32.526,ns_1@127.0.0.1:<0.21092.162>:compaction_daemon:try_to_cleanup_indexes:602]Cleaning up indexes for bucket `gamesim-sample`
        [ns_server:info,2013-04-10T20:52:32.529,ns_1@127.0.0.1:<0.21092.162>:compaction_daemon:spawn_bucket_compactor:561]Compacting bucket gamesim-sample with config:
        [{parallel_db_and_view_compaction,false}

        ,
        {database_fragmentation_threshold,{undefined,undefined}},
        {view_fragmentation_threshold,{undefined,undefined}}]
        [ns_server:debug,2013-04-10T20:52:32.530,ns_1@127.0.0.1:<0.21095.162>:compaction_daemon:bucket_needs_compaction:964]`gamesim-sample` data size is 905949, disk size is 996135
        [ns_server:debug,2013-04-10T20:52:32.530,ns_1@127.0.0.1:<0.21097.162>:compaction_daemon:view_needs_compaction:1121]`gamesim-sample/_design/players/main` data_size is 3573, disk_size is 53435
        [ns_server:debug,2013-04-10T20:52:32.530,ns_1@127.0.0.1:<0.21098.162>:compaction_daemon:view_needs_compaction:1121]`gamesim-sample/_design/players/replica` data_size is 0, disk_size is 4165
        [ns_server:debug,2013-04-10T20:52:32.530,ns_1@127.0.0.1:<0.21100.162>:compaction_daemon:view_needs_compaction:1121]`gamesim-sample/_design/dev_test/main` data_size is 37335, disk_size is 49316
        [ns_server:debug,2013-04-10T20:52:32.531,ns_1@127.0.0.1:<0.21101.162>:compaction_daemon:view_needs_compaction:1121]`gamesim-sample/_design/dev_test/replica` data_size is 0, disk_size is 4163
        [ns_server:debug,2013-04-10T20:52:32.531,ns_1@127.0.0.1:<0.21103.162>:compaction_daemon:view_needs_compaction:1121]`gamesim-sample/_design/dev_players/main` data_size is 3573, disk_size is 53435
        [ns_server:debug,2013-04-10T20:52:32.531,ns_1@127.0.0.1:<0.21104.162>:compaction_daemon:view_needs_compaction:1121]`gamesim-sample/_design/dev_players/replica` data_size is 0, disk_size is 4165
        [ns_server:info,2013-04-10T20:52:32.531,ns_1@127.0.0.1:<0.21105.162>:compaction_daemon:try_to_cleanup_indexes:602]Cleaning up indexes for bucket `beer-sample`
        [ns_server:info,2013-04-10T20:52:32.533,ns_1@127.0.0.1:<0.21105.162>:compaction_daemon:spawn_bucket_compactor:561]Compacting bucket beer-sample with config:
        [

        {parallel_db_and_view_compaction,false},
        {database_fragmentation_threshold,{undefined,undefined}},
        {view_fragmentation_threshold,{undefined,undefined}}]
        [ns_server:debug,2013-04-10T20:52:32.533,ns_1@127.0.0.1:<0.21108.162>:compaction_daemon:bucket_needs_compaction:964]`beer-sample` data size is 1430, disk size is 70079
        [ns_server:debug,2013-04-10T20:52:32.534,ns_1@127.0.0.1:<0.21110.162>:compaction_daemon:view_needs_compaction:1121]`beer-sample/_design/beer/main` data_size is 0, disk_size is 28770
        [ns_server:debug,2013-04-10T20:52:32.534,ns_1@127.0.0.1:<0.21111.162>:compaction_daemon:view_needs_compaction:1121]`beer-sample/_design/beer/replica` data_size is 0, disk_size is 4165
        [ns_server:info,2013-04-10T20:52:32.534,ns_1@127.0.0.1:<0.21112.162>:compaction_daemon:try_to_cleanup_indexes:602]Cleaning up indexes for bucket `default`
        [ns_server:info,2013-04-10T20:52:32.534,ns_1@127.0.0.1:<0.21112.162>:compaction_daemon:spawn_bucket_compactor:561]Compacting bucket default with config:
        [{parallel_db_and_view_compaction,false}

        ,
        {database_fragmentation_threshold,{undefined,undefined}},
        {view_fragmentation_threshold,{undefined,undefined}}]
        [ns_server:debug,2013-04-10T20:52:32.535,ns_1@127.0.0.1:<0.21115.162>:compaction_daemon:bucket_needs_compaction:964]`default` data size is 748764, disk size is 787194
        [ns_server:debug,2013-04-10T20:52:32.535,ns_1@127.0.0.1:compaction_daemon<0.4766.1>:compaction_daemon:handle_info:457]Finished compaction iteration.
        [ns_server:debug,2013-04-10T20:52:32.535,ns_1@127.0.0.1:compaction_daemon<0.4766.1>:compaction_daemon:schedule_next_compaction:1441]Finished compaction too soon. Next run will be in 30s

        Show
        perry Perry Krug added a comment - I tried reproducing this on my machine, and even when setting the threshold to 10GB for views and data files, the compaction still tries to run every 30 seconds: [ns_server:debug,2013-04-10T20:50:02.475,ns_1@127.0.0.1:compaction_daemon<0.4766.1>:compaction_daemon:handle_info:399] Starting compaction for the following buckets: [<<"gamesim-sample">>,<<"beer-sample">>,<<"default">>] [ns_server:info,2013-04-10T20:50:02.475,ns_1@127.0.0.1:<0.20205.162>:compaction_daemon:try_to_cleanup_indexes:602] Cleaning up indexes for bucket `gamesim-sample` [ns_server:info,2013-04-10T20:50:02.478,ns_1@127.0.0.1:<0.20205.162>:compaction_daemon:spawn_bucket_compactor:561] Compacting bucket gamesim-sample with config: [ {parallel_db_and_view_compaction,false}, {database_fragmentation_threshold,{undefined,10737418240}}, {view_fragmentation_threshold,{undefined,10737418240}}] [ns_server:debug,2013-04-10T20:50:02.479,ns_1@127.0.0.1:<0.20208.162>:compaction_daemon:bucket_needs_compaction:964] `gamesim-sample` data size is 905949, disk size is 996135 [ns_server:debug,2013-04-10T20:50:02.479,ns_1@127.0.0.1:<0.20210.162>:compaction_daemon:view_needs_compaction:1121] `gamesim-sample/_design/players/main` data_size is 3573, disk_size is 53435 [ns_server:debug,2013-04-10T20:50:02.480,ns_1@127.0.0.1:<0.20211.162>:compaction_daemon:view_needs_compaction:1121] `gamesim-sample/_design/players/replica` data_size is 0, disk_size is 4165 [ns_server:debug,2013-04-10T20:50:02.480,ns_1@127.0.0.1:<0.20213.162>:compaction_daemon:view_needs_compaction:1121] `gamesim-sample/_design/dev_test/main` data_size is 37335, disk_size is 49316 [ns_server:debug,2013-04-10T20:50:02.480,ns_1@127.0.0.1:<0.20214.162>:compaction_daemon:view_needs_compaction:1121] `gamesim-sample/_design/dev_test/replica` data_size is 0, disk_size is 4163 [ns_server:debug,2013-04-10T20:50:02.481,ns_1@127.0.0.1:<0.20216.162>:compaction_daemon:view_needs_compaction:1121] `gamesim-sample/_design/dev_players/main` data_size is 3573, disk_size is 53435 [ns_server:debug,2013-04-10T20:50:02.481,ns_1@127.0.0.1:<0.20217.162>:compaction_daemon:view_needs_compaction:1121] `gamesim-sample/_design/dev_players/replica` data_size is 0, disk_size is 4165 [ns_server:info,2013-04-10T20:50:02.481,ns_1@127.0.0.1:<0.20218.162>:compaction_daemon:try_to_cleanup_indexes:602] Cleaning up indexes for bucket `beer-sample` [ns_server:info,2013-04-10T20:50:02.484,ns_1@127.0.0.1:<0.20218.162>:compaction_daemon:spawn_bucket_compactor:561] Compacting bucket beer-sample with config: [{parallel_db_and_view_compaction,false} , {database_fragmentation_threshold,{undefined,10737418240}}, {view_fragmentation_threshold,{undefined,10737418240}}] [ns_server:debug,2013-04-10T20:50:02.484,ns_1@127.0.0.1:<0.20221.162>:compaction_daemon:bucket_needs_compaction:964] `beer-sample` data size is 1430, disk size is 70079 [ns_server:debug,2013-04-10T20:50:02.484,ns_1@127.0.0.1:<0.20223.162>:compaction_daemon:view_needs_compaction:1121] `beer-sample/_design/beer/main` data_size is 0, disk_size is 28770 [ns_server:debug,2013-04-10T20:50:02.485,ns_1@127.0.0.1:<0.20224.162>:compaction_daemon:view_needs_compaction:1121] `beer-sample/_design/beer/replica` data_size is 0, disk_size is 4165 [ns_server:info,2013-04-10T20:50:02.485,ns_1@127.0.0.1:<0.20225.162>:compaction_daemon:try_to_cleanup_indexes:602] Cleaning up indexes for bucket `default` [ns_server:info,2013-04-10T20:50:02.485,ns_1@127.0.0.1:<0.20225.162>:compaction_daemon:spawn_bucket_compactor:561] Compacting bucket default with config: [ {parallel_db_and_view_compaction,false}, {database_fragmentation_threshold,{undefined,10737418240}}, {view_fragmentation_threshold,{undefined,10737418240}}] [ns_server:debug,2013-04-10T20:50:02.486,ns_1@127.0.0.1:<0.20228.162>:compaction_daemon:bucket_needs_compaction:964] `default` data size is 748764, disk size is 787194 [ns_server:debug,2013-04-10T20:50:02.486,ns_1@127.0.0.1:compaction_daemon<0.4766.1>:compaction_daemon:handle_info:457] Finished compaction iteration. [ns_server:debug,2013-04-10T20:50:02.486,ns_1@127.0.0.1:compaction_daemon<0.4766.1>:compaction_daemon:schedule_next_compaction:1441] Finished compaction too soon. Next run will be in 30s And trying to turn it off altogether by unchecking all boxes: [ns_server:debug,2013-04-10T20:52:32.526,ns_1@127.0.0.1:compaction_daemon<0.4766.1>:compaction_daemon:handle_info:399] Starting compaction for the following buckets: [<<"gamesim-sample">>,<<"beer-sample">>,<<"default">>] [ns_server:info,2013-04-10T20:52:32.526,ns_1@127.0.0.1:<0.21092.162>:compaction_daemon:try_to_cleanup_indexes:602] Cleaning up indexes for bucket `gamesim-sample` [ns_server:info,2013-04-10T20:52:32.529,ns_1@127.0.0.1:<0.21092.162>:compaction_daemon:spawn_bucket_compactor:561] Compacting bucket gamesim-sample with config: [{parallel_db_and_view_compaction,false} , {database_fragmentation_threshold,{undefined,undefined}}, {view_fragmentation_threshold,{undefined,undefined}}] [ns_server:debug,2013-04-10T20:52:32.530,ns_1@127.0.0.1:<0.21095.162>:compaction_daemon:bucket_needs_compaction:964] `gamesim-sample` data size is 905949, disk size is 996135 [ns_server:debug,2013-04-10T20:52:32.530,ns_1@127.0.0.1:<0.21097.162>:compaction_daemon:view_needs_compaction:1121] `gamesim-sample/_design/players/main` data_size is 3573, disk_size is 53435 [ns_server:debug,2013-04-10T20:52:32.530,ns_1@127.0.0.1:<0.21098.162>:compaction_daemon:view_needs_compaction:1121] `gamesim-sample/_design/players/replica` data_size is 0, disk_size is 4165 [ns_server:debug,2013-04-10T20:52:32.530,ns_1@127.0.0.1:<0.21100.162>:compaction_daemon:view_needs_compaction:1121] `gamesim-sample/_design/dev_test/main` data_size is 37335, disk_size is 49316 [ns_server:debug,2013-04-10T20:52:32.531,ns_1@127.0.0.1:<0.21101.162>:compaction_daemon:view_needs_compaction:1121] `gamesim-sample/_design/dev_test/replica` data_size is 0, disk_size is 4163 [ns_server:debug,2013-04-10T20:52:32.531,ns_1@127.0.0.1:<0.21103.162>:compaction_daemon:view_needs_compaction:1121] `gamesim-sample/_design/dev_players/main` data_size is 3573, disk_size is 53435 [ns_server:debug,2013-04-10T20:52:32.531,ns_1@127.0.0.1:<0.21104.162>:compaction_daemon:view_needs_compaction:1121] `gamesim-sample/_design/dev_players/replica` data_size is 0, disk_size is 4165 [ns_server:info,2013-04-10T20:52:32.531,ns_1@127.0.0.1:<0.21105.162>:compaction_daemon:try_to_cleanup_indexes:602] Cleaning up indexes for bucket `beer-sample` [ns_server:info,2013-04-10T20:52:32.533,ns_1@127.0.0.1:<0.21105.162>:compaction_daemon:spawn_bucket_compactor:561] Compacting bucket beer-sample with config: [ {parallel_db_and_view_compaction,false}, {database_fragmentation_threshold,{undefined,undefined}}, {view_fragmentation_threshold,{undefined,undefined}}] [ns_server:debug,2013-04-10T20:52:32.533,ns_1@127.0.0.1:<0.21108.162>:compaction_daemon:bucket_needs_compaction:964] `beer-sample` data size is 1430, disk size is 70079 [ns_server:debug,2013-04-10T20:52:32.534,ns_1@127.0.0.1:<0.21110.162>:compaction_daemon:view_needs_compaction:1121] `beer-sample/_design/beer/main` data_size is 0, disk_size is 28770 [ns_server:debug,2013-04-10T20:52:32.534,ns_1@127.0.0.1:<0.21111.162>:compaction_daemon:view_needs_compaction:1121] `beer-sample/_design/beer/replica` data_size is 0, disk_size is 4165 [ns_server:info,2013-04-10T20:52:32.534,ns_1@127.0.0.1:<0.21112.162>:compaction_daemon:try_to_cleanup_indexes:602] Cleaning up indexes for bucket `default` [ns_server:info,2013-04-10T20:52:32.534,ns_1@127.0.0.1:<0.21112.162>:compaction_daemon:spawn_bucket_compactor:561] Compacting bucket default with config: [{parallel_db_and_view_compaction,false} , {database_fragmentation_threshold,{undefined,undefined}}, {view_fragmentation_threshold,{undefined,undefined}}] [ns_server:debug,2013-04-10T20:52:32.535,ns_1@127.0.0.1:<0.21115.162>:compaction_daemon:bucket_needs_compaction:964] `default` data size is 748764, disk size is 787194 [ns_server:debug,2013-04-10T20:52:32.535,ns_1@127.0.0.1:compaction_daemon<0.4766.1>:compaction_daemon:handle_info:457] Finished compaction iteration. [ns_server:debug,2013-04-10T20:52:32.535,ns_1@127.0.0.1:compaction_daemon<0.4766.1>:compaction_daemon:schedule_next_compaction:1441] Finished compaction too soon. Next run will be in 30s
        Hide
        alkondratenko Aleksey Kondratenko (Inactive) added a comment -

        This is not actual compaction.

        This is our debug messages from autocompaction daemon that it checks everything correctly. It's not really compacting anything each 30 seconds. Just checks fragmentation, disk space and etc.

        Show
        alkondratenko Aleksey Kondratenko (Inactive) added a comment - This is not actual compaction. This is our debug messages from autocompaction daemon that it checks everything correctly. It's not really compacting anything each 30 seconds. Just checks fragmentation, disk space and etc.
        Hide
        maria Maria McDuff (Inactive) added a comment -

        perry, can this be closed now?

        Show
        maria Maria McDuff (Inactive) added a comment - perry, can this be closed now?
        Hide
        maria Maria McDuff (Inactive) added a comment -

        pls re-open if necessary. Thanks.

        Show
        maria Maria McDuff (Inactive) added a comment - pls re-open if necessary. Thanks.

          People

          • Assignee:
            perry Perry Krug
            Reporter:
            perry Perry Krug
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes