Currently, calling QueryRequest.Pretty(bool) only affects the actual HTTP request if pretty is set to true. In this case it adds pretty=true to the request, which is already the default on the server. Therefore there is no way at the SDK level to reduce network traffic by having the query server not include whitespace.
- the tests still fail on CI, we can raise another ticket to fix those or re-open this ticket.
Jeffry Morris June 23, 2017 at 2:03 AM
-
No pressure, lets go ahead and do after .
-Jeff
Brant Burnett June 23, 2017 at 1:36 AM
Edited
This test can be fixed by dropping TestCase(false), which fails because Server < 4.5 doesn't support the pretty print parameter.
However, this reduces the quality of the test on versions >= 4.5. Instead, I propose we wait a short bit until the work on is complete. We can then use the version test to do an Ignore on these test cases against older server versions that don't support the parameter.
If time pressure is an issue, though, we can remove the test and add it back later. Another option would be to add a category that allows the QE team to exclude the test against older server versions.
Brant
Jeffry Morris June 22, 2017 at 10:29 PM
- we plan to be code complete by Monday. for 2.4.6
Brant Burnett June 22, 2017 at 9:03 PM
I'll try to work on the integration test issue tonight, this weekend at the latest. I know you guys have a release deadline soon.
Brant
Fixed
Pinned fields
Click on the next to a field label to start pinning.
Currently, calling QueryRequest.Pretty(bool) only affects the actual HTTP request if pretty is set to true. In this case it adds pretty=true to the request, which is already the default on the server. Therefore there is no way at the SDK level to reduce network traffic by having the query server not include whitespace.