Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-1778

Improve SendWithDurabilityAsync testability using mocks

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.4
    • Component/s: None
    • Labels:
      None

      Description

      SendWithDurabilityAsync internally uses SendWithRetry to dispatch the original request before polling with observe operations to satisfy durability requirements.

      However, the current implementation is not testable because a TaskCompletionSource cannot be passed into SendWithDurabillity, and in turn onto SendWithRetry, so it's not possible to mock the result. Ideally a TCS would be an optional parameter in the same way SendWithRetry exposes for testing.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          There are no comments yet on this issue.

            People

            • Assignee:
              jmorris Jeff Morris
              Reporter:
              mike.goldsmith Michael Goldsmith
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty

                  Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.