Fixed
Pinned fields
Click on the next to a field label to start pinning.
Details
Assignee
Brant BurnettBrant BurnettReporter
Brant BurnettBrant BurnettLabels
Story Points
1Components
Fix versions
Priority
MajorInstabug
Open Instabug
Details
Details
Assignee
Brant Burnett
Brant BurnettReporter
Brant Burnett
Brant BurnettLabels
Story Points
1
Components
Fix versions
Priority
Instabug
Open Instabug
PagerDuty
PagerDuty
PagerDuty
Sentry
Sentry
Sentry
Zendesk Support
Zendesk Support
Zendesk Support
Created April 2, 2019 at 1:04 AM
Updated April 24, 2020 at 8:24 PM
Resolved April 4, 2019 at 11:10 PM
Returning a byte array from Write limits our options for memory management. We could refactor to an IMemoryOwner<byte>, but that puts the onus on the caller to handle disposing.
On the other hand, if we refactor "byte[] Write()" to "Task SendAsync(IConnection connection), this makes the interface simpler. Any kind of memory (byte array or ReadOnlyMemory<byte>) can be passed on to IConnection, without changing memory ownership. Additionally, the caller is no longer required to pass in op.Completed as a parameter to IConnection.SendAsync, the operation can provide this itself, which creates a cleaner API.