Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Eliminate redundant tests. I see there are some repetitive tests which differ only by 1-2 parameters. For example, we don't need individual functions for each scenario of observe, and it should be possible to abstract this all into a single function, with different tests just calling into that function with different parameters.

      I recall that you brought this up as a concern before; now it's a task

        Issue Links

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Show
          saakshi.manocha Saakshi Manocha added a comment - http://review.couchbase.org/#/c/23202/
          Hide
          mnunberg Mark Nunberg added a comment -

          I've sectioned out the previous bug into an NCBC issue. In general any changes to the SDKs themselves should be branched out into issues which touch those specific projects, with the SDKQE task tracking them.

          Show
          mnunberg Mark Nunberg added a comment - I've sectioned out the previous bug into an NCBC issue. In general any changes to the SDKs themselves should be branched out into issues which touch those specific projects, with the SDKQE task tracking them.
          Hide
          saakshi.manocha Saakshi Manocha added a comment - - edited

          updated files attached for review :
          couchbase.tests.changedfiles.zip

          Show
          saakshi.manocha Saakshi Manocha added a comment - - edited updated files attached for review : couchbase.tests.changedfiles.zip
          Hide
          saakshi.manocha Saakshi Manocha added a comment -
          Show
          saakshi.manocha Saakshi Manocha added a comment - please review: http://review.couchbase.org/#/c/23430/
          Hide
          saakshi.manocha Saakshi Manocha added a comment -

          Mark to review the changes updated in Gerrit

          Show
          saakshi.manocha Saakshi Manocha added a comment - Mark to review the changes updated in Gerrit
          Hide
          saakshi.manocha Saakshi Manocha added a comment -

          moved this task from SDKQE project to NCBC, as per mail from Matt so that we can use NCBC in comment while submitting code in gerrit.
          updated comment in gerrit and submitted a new patch set.,
          please review http://review.couchbase.org/#/c/23604/

          Show
          saakshi.manocha Saakshi Manocha added a comment - moved this task from SDKQE project to NCBC, as per mail from Matt so that we can use NCBC in comment while submitting code in gerrit. updated comment in gerrit and submitted a new patch set., please review http://review.couchbase.org/#/c/23604/
          Hide
          ingenthr Matt Ingenthron added a comment -

          Saakshi: it's not so much that this task needed to be moved, but an underlying NCBC enhancement issue needed to be created-- even one with just a one line summary of what's to be done.

          NCBC tracks this product/project, so we should always be able to see the changes in a version via this issue tracker and cross reference that with the code changes.

          Thanks!

          Show
          ingenthr Matt Ingenthron added a comment - Saakshi: it's not so much that this task needed to be moved, but an underlying NCBC enhancement issue needed to be created-- even one with just a one line summary of what's to be done. NCBC tracks this product/project, so we should always be able to see the changes in a version via this issue tracker and cross reference that with the code changes. Thanks!

            People

            • Assignee:
              saakshi.manocha Saakshi Manocha
              Reporter:
              mnunberg Mark Nunberg
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes