Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-2246

QueryOptions do not align with the RFC

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • 3.0.0-beta.4
    • None
    • None
    • None
    • 1
    • SDK1: GA and Priority List

    Description

      Looking through the QueryOptions, I identified the following inconsistencies:

      • AddCredentials must not be present
      • AddNamedParameter and AddPositionalParameter do not align with the rfc: it's either parameters with overloads or namedParameters and positionalParameters for languages that do not support overloads
      • AdHoc => Adhoc
      • AutoExecute should not be exposed -> this is purely internal to work with enhanced prepared statements
      • Encoding is not part of the spec (why would allow the user to send a different encoding?)
      • Some methods have "with" prefix while others do not
      • Signature(bool) is not defined on the rfc
      • ScanCapacity should be called ScanCap
      • PipelineCapacity should be called PipelineCap
      • RawParameter should be called Raw

      In general I'm not sure how some of those methods should work on the QueryOptions - why does it have a "statement" method? The user provided it as part of the query itself. Looking at it I think the options conflate the options a user can set with what actually gets created and sent on the wire down the line .. maybe this needs to be broken up?

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              jmorris Jeff Morris
              daschl Michael Nitschinger
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty