Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-2298

CancellationToken and CancellationTokenSource management needed

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Duplicate
    • 3.0.0-beta.4
    • 3.0.6
    • library
    • None
    • 1

    Description

      As a complement to NCBC-2290, we need some sort of process/pattern/whatever for managing CancellationTokenSource and CancellationTokens themselves passed into the SDK.

      Currently the RetryOrchestrator does some work here in that if it encounters a CancellationToken.none, it will create a CancellationTokenSource with the timeout. This CTS, needs to be disposed, but currently its not. Additionally, throughout the source you will find child CTS's, these also need to managed.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            jmorris Jeff Morris added a comment -

            Fixed by NCBC-2557

            jmorris Jeff Morris added a comment - Fixed by NCBC-2557

            People

              Unassigned Unassigned
              jmorris Jeff Morris
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty