Unnecessary allocation in classes implementing IOperation

Description

all the implementations do something like this:
public List<RetryReason> RetryReasons { get; set; } = new List<RetryReason>();
public IRetryStrategy RetryStrategy { get; set; } = new BestEffortRetryStrategy(new ControlledBackoff());

  • most operations never need these properties

  • they could be singletons as they dont appear to store any per operation state.

Environment

None

Gerrit Reviews

None

Release Notes Description

None

Activity

Show:

Jeffry Morris November 30, 2020 at 8:02 PM

Temporarily added to backlog as this won't make the 3.1.0 cutoff.

Jeffry Morris September 22, 2020 at 5:03 PM

-

Thanks for submitting this issue! I assigned it to the next release scheduled for the first week of October.

-Jeff

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

CVSS/Severity

High

Story Points

Components

Sprint

Fix versions

Affects versions

Priority

Instabug

Open Instabug

PagerDuty

Sentry

Zendesk Support

Created September 22, 2020 at 2:39 PM
Updated December 3, 2020 at 1:59 AM
Resolved December 3, 2020 at 1:59 AM
Instabug