Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-2653

Unnecessary allocation in classes implementing IOperation

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.0.5
    • 3.1.1
    • library
    • None
    • 1
    • SDK 44: Txns, SDK 3.1, Docs
    • High

    Description

      all the implementations do something like this:
      public List<RetryReason> RetryReasons { get; set; } = new List<RetryReason>();
      public IRetryStrategy RetryStrategy { get; set; } = new BestEffortRetryStrategy(new ControlledBackoff());

      • most operations never need these properties
      • they could be singletons as they dont appear to store any per operation state.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          jmorris Jeff Morris added a comment -

          Tommy Jakobsen -

          Thanks for submitting this issue! I assigned it to the next release scheduled for the first week of October.

          -Jeff

          jmorris Jeff Morris added a comment - Tommy Jakobsen - Thanks for submitting this issue! I assigned it to the next release scheduled for the first week of October. -Jeff
          jmorris Jeff Morris added a comment -

          Temporarily added to backlog as this won't make the 3.1.0 cutoff.

          jmorris Jeff Morris added a comment - Temporarily added to backlog as this won't make the 3.1.0 cutoff.

          People

            jmorris Jeff Morris
            tommyja Tommy Jakobsen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty