Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-2791

GetResult uses AddMilliseconds instead of AddSeconds for expiry

    XMLWordPrintable

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.1.0
    • 3.1.2
    • None
    • None
    • 1

    Description

       

      #if NETSTANDARD2_1
       _expiryTime = DateTime.UnixEpoch.AddMilliseconds(ms).ToLocalTime();
      #else
       var unixEpoch = new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc);
       _expiryTime = unixEpoch.AddSeconds(ms).ToLocalTime();
      #endif

      maybe should be

       

      #if (NETSTANDARD || NETCOREAPP) && !NETSTANDARD2_0
       _expiryTime = DateTime.UnixEpoch.AddMilliseconds(ms).ToLocalTime();
      #else
       var unixEpoch = new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc);
       _expiryTime = unixEpoch.AddMilliseconds(ms).ToLocalTime();
      #endif

      Attachments

        For Gerrit Dashboard: NCBC-2791
        # Subject Branch Project Status CR V

        Activity

          There are no comments yet on this issue.

          People

            jmorris Jeff Morris
            richard.ponton Richard Ponton
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty