"if you don't want to do LoggerMessage, I'd still at least switch this to passing the values as parameters. That will avoid the cost of string formatting when unnecessary and allow JSON structured logging. It's not quite as performant as LoggerMessage (still has heap alloc, boxing, and format parsing costs), but still much better than string interpolation. Also, note that LoggerMessage is very easy to do as we're already doing it in some of the hot paths in this SDK. So it's not like we have a lot of setup to do to make it work. https://github.com/couchbase/couchbase-net-client/blob/bb7a9c37e2f504d8f1d1b19208989af330a0577a/src/Couchbase/Core/Retry/RetryOrchestrator.cs#L388"
Environment
None
Gerrit Reviews
None
Release Notes Description
None
Activity
Show:
Fixed
Pinned fields
Click on the next to a field label to start pinning.
From: https://review.couchbase.org/c/couchbase-net-client/+/186451
"if you don't want to do LoggerMessage, I'd still at least switch this to passing the values as parameters. That will avoid the cost of string formatting when unnecessary and allow JSON structured logging. It's not quite as performant as LoggerMessage (still has heap alloc, boxing, and format parsing costs), but still much better than string interpolation. Also, note that LoggerMessage is very easy to do as we're already doing it in some of the hot paths in this SDK. So it's not like we have a lot of setup to do to make it work. https://github.com/couchbase/couchbase-net-client/blob/bb7a9c37e2f504d8f1d1b19208989af330a0577a/src/Couchbase/Core/Retry/RetryOrchestrator.cs#L388"