Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-3354

Use LoggerMessage for logging in Channel* classes

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 3.4.7
    • 3.4.3
    • library
    • None
    • 2
    • SDK10, SDK20, SDK22

    Description

      From: https://review.couchbase.org/c/couchbase-net-client/+/186451

      "if you don't want to do LoggerMessage, I'd still at least switch this to passing the values as parameters. That will avoid the cost of string formatting when unnecessary and allow JSON structured logging. It's not quite as performant as LoggerMessage (still has heap alloc, boxing, and format parsing costs), but still much better than string interpolation. Also, note that LoggerMessage is very easy to do as we're already doing it in some of the hot paths in this SDK. So it's not like we have a lot of setup to do to make it work. https://github.com/couchbase/couchbase-net-client/blob/bb7a9c37e2f504d8f1d1b19208989af330a0577a/src/Couchbase/Core/Retry/RetryOrchestrator.cs#L388"

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            emilien.bevierre Emilien Bevierre
            jmorris Jeff Morris
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty