Details
-
Improvement
-
Resolution: Unresolved
-
Minor
-
None
-
None
-
None
Description
Currently, we use the custom ITypeSerializer to deserialize the entire query response. This can, in theory, cause problems with inconsistent deserialization of metadata. An example is NCBC-3217 where AdditionalProperies may be deserialized as either System.Text.Json.JsonElement or Newtonsoft.Json.Linq.JToken. This could be further exacerbated by a custom serializer that can't handle AdditionalProperties, struggles with our custom property name attributes, and more.
Instead, the custom deserializer should apply only to the rows returned by the query, not any system-level metadata such as errors, metrics, etc.
Attachments
Gerrit Reviews
For Gerrit Dashboard: NCBC-3419 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
207542,4 | NCBC-3419: [WIP] Always use System.Text.Json for outer query result deserialization | master | couchbase-net-client | Status: NEW | 0 | +1 |