Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-416

Method overloading ambiguity with named parameters

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.4
    • Fix Version/s: 1.3.5
    • Component/s: library
    • Labels:
      None

      Description

      "method overloading is differentiated with return type only hence wrong method was invoked from
      line 1311: public IView GetView(string designName, string viewName)
      In order to fix this i have added named parameter from the correct method definition."

      Ref: https://github.com/couchbase/couchbase-net-client/pull/13

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          jmorris Jeff Morris added a comment -

          We need to ensure that this is the only case.

          Show
          jmorris Jeff Morris added a comment - We need to ensure that this is the only case.
          Hide
          wayne Wayne Siu added a comment -

          Hi Jeff,
          Can you help define the test case(s) for this issue? I'll have SDKQE to script and automate it afterward. Thanks.

          Show
          wayne Wayne Siu added a comment - Hi Jeff, Can you help define the test case(s) for this issue? I'll have SDKQE to script and automate it afterward. Thanks.
          Hide
          jmorris Jeff Morris added a comment - - edited

          Wayne -

          Assume a view as such:

          function (doc, meta)

          { emit(meta.id, null); }

          When you iterate over the results of the client, it should return a list of the keys. It currently returns null, even though the TotalRows will return a value > 0 if there are keys available.

          var view = client.GetView("utils", "allKeys");
          foreach(var row in view)

          { //this should iterate through the keys. }

          I'll add a unit test that covers it,

          -Jeff

          Show
          jmorris Jeff Morris added a comment - - edited Wayne - Assume a view as such: function (doc, meta) { emit(meta.id, null); } When you iterate over the results of the client, it should return a list of the keys. It currently returns null, even though the TotalRows will return a value > 0 if there are keys available. var view = client.GetView("utils", "allKeys"); foreach(var row in view) { //this should iterate through the keys. } I'll add a unit test that covers it, -Jeff
          Hide
          jmorris Jeff Morris added a comment -

          Fixed in 1.3.5 release

          Show
          jmorris Jeff Morris added a comment - Fixed in 1.3.5 release

            People

            • Assignee:
              jmorris Jeff Morris
              Reporter:
              jmorris Jeff Morris
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty

                  Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.