Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-958

Provide sane checks for max and min pool sizes.

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Done
    • 2.1.3
    • 2.3.9
    • library
    • None
    • SDK50: Sample App, DNS-SRV

    Description

      see https://forums.couchbase.com/t/the-cluster-does-not-support-query-services/4608/3

      The PoolConfiguration.MaxSize and MinSize need an upper bound that doesn't cause side effects. If these bounds are exceeded, the client shall through an exception and stop bootstrapping.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          Gerrit review is now available.

          However Brant Burnett has indicated the initially selected maximum value of 20 may be too low. We need to agree on an acceptable max and update the value before it should be accepted.

          mike.goldsmith Michael Goldsmith added a comment - Gerrit review is now available. However Brant Burnett has indicated the initially selected maximum value of 20 may be too low. We need to agree on an acceptable max and update the value before it should be accepted.
          jmorris Jeff Morris added a comment -

          Mike -

          We ran into a problem during testing: the property setters for MinSize and MaxSize are now private and its a breaking change. SDKD uses those properties and no longer compiles. I think we need to re-work the commit so that it uses backing variables, old school style, and then do the min and max checks in the setter before assigning the value to the backing field.

          -Jeff

          jmorris Jeff Morris added a comment - Mike - We ran into a problem during testing: the property setters for MinSize and MaxSize are now private and its a breaking change. SDKD uses those properties and no longer compiles. I think we need to re-work the commit so that it uses backing variables, old school style, and then do the min and max checks in the setter before assigning the value to the backing field. -Jeff

          People

            mike.goldsmith Michael Goldsmith
            jmorris Jeff Morris
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty