Uploaded image for project: 'Couchbase Python Client Library'
  1. Couchbase Python Client Library
  2. PYCBC-1147

Remove hack in fts.c after corresponding LCB issue is fixed

    XMLWordPrintable

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.2.1
    • library
    • None
    • 1

    Description

      It turns out recent changes make it possible for lcb_search to call the callback before returning an error. That segfaults our bindings, as the callback expects the us to already have released the gil. That is CCBC-1428. So, once that is fixed lets use it, and remove the hack. See fts.c:57 – basically the conditional should go away, and we should always call PYCBC_CONN_THR_END (like all other callbacks).

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            There are no comments yet on this issue.

            People

              jared.casey Jared Casey
              david.kelly David Kelly
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty