Uploaded image for project: 'Couchbase Python Client Library'
  1. Couchbase Python Client Library
  2. PYCBC-424

Rename subdoc create / upsert flags to match RFC

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.3.0
    • None
    • None

    Description

      The sdk-rfc for 5.0 additions calls for a param, upsert_document, which will create the document if it does not exist.  This was implemented as either create_doc or upsert_doc and should be upsert_document and insert_document per the RFC.

      Attachments

        For Gerrit Dashboard: PYCBC-424
        # Subject Branch Project Status CR V

        Activity

          I later found it's implemented as upsert_doc, insert_doc.  Needs to be corrected to follow the RFC.

          ingenthr Matt Ingenthron added a comment - I later found it's implemented as upsert_doc, insert_doc.  Needs to be corrected to follow the RFC.

          Further update, it's upsert_document, insert_document per the sdk-rfc.  Some ambiguity was fixed just now.

          ingenthr Matt Ingenthron added a comment - Further update, it's upsert_document, insert_document per the sdk-rfc.  Some ambiguity was fixed just now.

          Late breaking news, upsert_doc and insert_doc should be used if that is more inline with the SDK's approach. There was some confusion between Brett Lawson and I, now resolved.  He's amending the RFC.

          Can you see if we should go back to _doc from _document based on what else is in the SDK.  It's a judgement call Michael Goldsmith, and yours is as good as mine.

          ingenthr Matt Ingenthron added a comment - Late breaking news, upsert_doc and insert_doc should be used if that is more inline with the SDK's approach. There was some confusion between Brett Lawson and I, now resolved.  He's amending the RFC. Can you see if we should go back to _doc from _document based on what else is in the SDK.  It's a judgement call Michael Goldsmith , and yours is as good as mine.
          Ellis.Breen Ellis Breen added a comment -

          Reverted changes as suggested.

          Ellis.Breen Ellis Breen added a comment - Reverted changes as suggested.
          Ellis.Breen Ellis Breen added a comment -

          Reverted change as suggested.

          Ellis.Breen Ellis Breen added a comment - Reverted change as suggested.

          People

            Ellis.Breen Ellis Breen
            ingenthr Matt Ingenthron
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                PagerDuty