Uploaded image for project: 'Couchbase Python Client Library'
  1. Couchbase Python Client Library
  2. PYCBC-716

Tests should not try to do 6.5-specific tests against a 6.0 server

    XMLWordPrintable

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0-beta.3
    • None
    • None
    • 1
    • SDK1: GA and Priority List

    Description

      We have a number of tests that fail because they are trying to upsert a named collection into a bucket, for instance, against a 6.0 server.  We should be slightly more clever here, and either make the tests notice that and use the defaultCollection (when possible) and/or skip tests that rely on 6.5 features.  

      For groups, I did this already by noticing that we got a 404 back when trying to create a group.  In that case we skipped a few tests.  Perhaps now with recent error handling changes, we will get back a NOT_SUPPORTED error and we can use that?  And similarly for scopes, collections, etc...

      Attachments

        For Gerrit Dashboard: PYCBC-716
        # Subject Branch Project Status CR V

        Activity

          david.kelly David Kelly added a comment -

          Note also that for groups, we do the http request ourselves vs going through libcouchbase.  For other calls via libcouchbase, we can get the LCB_ERR_NOT_SUPPORTED exceptions so this should be the way to go.

          david.kelly David Kelly added a comment - Note also that for groups, we do the http request ourselves vs going through libcouchbase.  For other calls via libcouchbase, we can get the LCB_ERR_NOT_SUPPORTED exceptions so this should be the way to go.
          david.kelly David Kelly added a comment -

          Actually, getting all collections or scopes, etc.. is also done with http calls rather than an api for it in libcouchbase!  So - using the same decorators and so on as for groups.

          david.kelly David Kelly added a comment - Actually, getting all collections or scopes, etc.. is also done with http calls rather than an api for it in libcouchbase!  So - using the same decorators and so on as for groups.
          david.kelly David Kelly added a comment -

          The gerrit change fixed most of the issues we've seen so far. I'll keep this open only to remind us to do another sweep shortly.

          david.kelly David Kelly added a comment - The gerrit change fixed most of the issues we've seen so far. I'll keep this open only to remind us to do another sweep shortly.
          david.kelly David Kelly added a comment -

          did another sweep, looks like we are good. There are real test failures, but none of the ones that we used to have which were just 6.5 vs 6.0 stuff...

          david.kelly David Kelly added a comment - did another sweep, looks like we are good. There are real test failures, but none of the ones that we used to have which were just 6.5 vs 6.0 stuff...

          People

            david.kelly David Kelly
            david.kelly David Kelly
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty