Uploaded image for project: 'Couchbase Python Client Library'
  1. Couchbase Python Client Library
  2. PYCBC-754

KV Get has invalid named args

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0-rc
    • None
    • None
    • 1
    • SDK7: Devguide Antorized, Docs

    Description

      As seen in: https://github.com/couchbase/couchbase-python-client/blob/master/couchbase/collection.py#L271

                  project=None,  # type: Iterable[str]
                  expiry=None,  # type: timedelta
                  quiet=None,  # type: bool
                  replica=False,  # type: bool
                  no_format=False  # type: bool
      

      project looks good. Replica should not be there. What is no_fomat doing?

      Also note that expiry should be called withExpiry according to RFC

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          Ellis.Breen Ellis Breen added a comment -

          Agreed replica should be gone. no_format is an SDK-specific option from SDK2. Will attempt to reevaluate.

          Ellis.Breen Ellis Breen added a comment - Agreed replica should be gone. no_format is an SDK-specific option from SDK2. Will attempt to reevaluate.
          david.kelly David Kelly added a comment -

          This is fixed, from some previous collection interface work

          david.kelly David Kelly added a comment - This is fixed, from some previous collection interface work
          david.kelly David Kelly added a comment - - edited

          oops – actually there are still some in there. Reopening.

          For instance collection.insert, collection.replace have 'em

          david.kelly David Kelly added a comment - - edited oops – actually there are still some in there. Reopening. For instance collection.insert , collection.replace have 'em
          david.kelly David Kelly added a comment -

          http://review.couchbase.org/#/c/122670/ fixed it. But it was merged with a typo in the commit message so it doesn't show up here in Jira

          david.kelly David Kelly added a comment - http://review.couchbase.org/#/c/122670/ fixed it. But it was merged with a typo in the commit message so it doesn't show up here in Jira

          People

            david.kelly David Kelly
            daschl Michael Nitschinger
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty