Uploaded image for project: 'Couchbase Python Client Library'
  1. Couchbase Python Client Library
  2. PYCBC-771

Mark multi-operations as volatile until sdk-rfc done

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0-rc
    • None
    • None
    • 1
    • SDK7: Devguide Antorized, Docs

    Description

      Things like all the multi_touch, multi_replace, multi_append, ... are to be sdk-rfc'd later. Mark the interface as volatile for now and update to be philosophically inline with sdk3.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          Ellis.Breen Ellis Breen added a comment - - edited

          I hadn't exposed these, but then some internal customers wanted them. There are also doubtless quite a few external customers that use it. They're there for performance reasons, primarily. I guess if we could prove there's not much of a performance advantage any more they could go... Not sure if there are other semantic differences though.

          Ellis.Breen Ellis Breen added a comment - - edited I hadn't exposed these, but then some internal customers wanted them. There are also doubtless quite a few external customers that use it. They're there for performance reasons, primarily. I guess if we could prove there's not much of a performance advantage any more they could go... Not sure if there are other semantic differences though.
          david.kelly David Kelly added a comment -

          Honestly I like them – if they have any performance advantage I'd want to keep 'em. Just filed this in case it is an issue not to follow the letter of the RFC.

          david.kelly David Kelly added a comment - Honestly I like them – if they have any performance advantage I'd want to keep 'em. Just filed this in case it is an issue not to follow the letter of the RFC.
          Ellis.Breen Ellis Breen added a comment -

          Accepted for consideration, though most likely will be kept at least as an internal feature.

          Ellis.Breen Ellis Breen added a comment - Accepted for consideration, though most likely will be kept at least as an internal feature.
          Ellis.Breen Ellis Breen added a comment - - edited

          On further consideration, I think we shouldn't expose these methods as 'stable' or even 'volatile' to the public until https://issues.couchbase.com/browse/PYCBC-776 is addressed. However QE are using these, so either we need to collaborate with them to work around their (probably temporary) removal before we do so, or mark them as @internal. The former inconveniences QE, but the latter risks publicising the methods to the userbase before PYCBC-776 is addressed.

          Have mentioned PYCBC-776 to QE, and anyone is welcome to propose a solution/changeset for it.

          Ellis.Breen Ellis Breen added a comment - - edited On further consideration, I think we shouldn't expose these methods as 'stable' or even 'volatile' to the public until https://issues.couchbase.com/browse/PYCBC-776 is addressed. However QE are using these, so either we need to collaborate with them to work around their (probably temporary) removal before we do so, or mark them as @internal. The former inconveniences QE, but the latter risks publicising the methods to the userbase before PYCBC-776 is addressed. Have mentioned PYCBC-776 to QE, and anyone is welcome to propose a solution/changeset for it.
          Ellis.Breen Ellis Breen added a comment -

          Decision has been made to mark this as volatile, which on further reflection would be accurate.

          Ellis.Breen Ellis Breen added a comment - Decision has been made to mark this as volatile, which on further reflection would be accurate.

          People

            Ellis.Breen Ellis Breen
            david.kelly David Kelly
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty