Uploaded image for project: 'Couchbase Python Client Library'
  1. Couchbase Python Client Library
  2. PYCBC-774

Collection.get_all_replicas needs proper implementation

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0-rc
    • None
    • None
    • 1
    • SDK3: Docs

    Description

      The existing C bindings deliver just one document, so we currently raise a NotImplemented until correcting this.

      The fix could be just properly getting the LCB_REPLICA_MODE_ALL properly passed into LCB, except that the value callback tries to make a dict keyed on the document key. So, even if the value callback does get called multiple times, it will overwrite the others. So probably that callback needs to be more clever as well.

      Attachments

        For Gerrit Dashboard: PYCBC-774
        # Subject Branch Project Status CR V

        Activity

          david.kelly David Kelly added a comment -

          While we are at it, lets figure out what to to about LCB only returning all the replica results. The spec indicated that we'd also get the active one, and we would have a flag to tell us that. But I don't see it in LCB – maybe that is intentional?

          david.kelly David Kelly added a comment - While we are at it, lets figure out what to to about LCB only returning all the replica results. The spec indicated that we'd also get the active one, and we would have a flag to tell us that. But I don't see it in LCB – maybe that is intentional?
          david.kelly David Kelly added a comment -

          https://issues.couchbase.com/browse/CCBC-1169 filed for LCB issue – we can deal with is_replica when that is fixed – should be relatively simple, and there is an issue for it.

          david.kelly David Kelly added a comment - https://issues.couchbase.com/browse/CCBC-1169 filed for LCB issue – we can deal with is_replica when that is fixed – should be relatively simple, and there is an issue for it.

          People

            david.kelly David Kelly
            david.kelly David Kelly
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty