Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0-beta.3
    • 3.0.0-rc
    • None
    • None
    • 1
    • SDK9: Coll/Txn/Doc chipping, SDK11: Coll/Txn/Docs More Chip

    Attachments

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

      Activity

        david.kelly David Kelly added a comment -

        We may have an issue with LCB returning the error contexts – see CCBC-1193. However we still need to actually expose it - and since the RFC wants objects and not just a dict, there is some work to be done while we are looking into the lcb issue. At first glance we do call lcb_resp_get_error_ref and lcb_resp_get_error_context like you would expect, so maybe first thing here is to make the objects, be sure they are exposed in CouchbaseError, and go from there.

        david.kelly David Kelly added a comment - We may have an issue with LCB returning the error contexts – see CCBC-1193 . However we still need to actually expose it - and since the RFC wants objects and not just a dict, there is some work to be done while we are looking into the lcb issue. At first glance we do call lcb_resp_get_error_ref and lcb_resp_get_error_context like you would expect, so maybe first thing here is to make the objects, be sure they are exposed in CouchbaseError , and go from there.
        david.kelly David Kelly added a comment -

        Actually, the lcb_resp_get_error_context comes from the server only on some errors.  Instead, the operation's error context comes from lcb_respXXX_error_context where XXX is the operation you just performed.  This seems to be the main thing to implement here.  A bonus would be adding in the extra context (and perhaps the ref) when they are present, as extra error context info.  

        david.kelly David Kelly added a comment - Actually, the lcb_resp_get_error_context comes from the server only on some errors.  Instead, the operation's error context comes from lcb_respXXX_error_context where XXX is the operation you just performed.  This seems to be the main thing to implement here.  A bonus would be adding in the extra context (and perhaps the ref) when they are present, as extra error context info.  

        Just a quick note that I think the context is required per the error handling sdk-rfc, so it may not be a "bonus" per se.

        ingenthr Matt Ingenthron added a comment - Just a quick note that I think the context is required per the error handling sdk-rfc, so it may not be a "bonus" per se.
        david.kelly David Kelly added a comment -

        True Matt Ingenthron - I think the stuff that only comes back from the server (which only sometimes comes back at all) is what we get from lcb_resp_get_error_context and that is the extended error info and ref mentioned in the RFC.  Yea not a bonus, but part of the spec for sure.   Thx!

        david.kelly David Kelly added a comment - True Matt Ingenthron  - I think the stuff that only comes back from the server (which only sometimes comes back at all) is what we get from lcb_resp_get_error_context and that is the extended error info and ref mentioned in the RFC.  Yea not a bonus, but part of the spec for sure.   Thx!

        People

          david.kelly David Kelly
          Ellis.Breen Ellis Breen
          Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved:

            Gerrit Reviews

              There are no open Gerrit changes

              PagerDuty