Uploaded image for project: 'Couchbase Python Client Library'
  1. Couchbase Python Client Library
  2. PYCBC-797

Bucket.ping needs to respect the timeout in the options if any

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 3.0.0-beta.3
    • 3.0.7
    • library
    • None
    • 1
    • SDK13: Coll/Txn/Docs More Chip, SDK15: Ruby/Coll/Docs, SDK46: TTL Imp., Bdura, Docs

    Description

      Currently you cannot set one - no lcb_cmdping_timeout or similar. There is a ticket for that - CCBC-1175. When that has been implemented, then we can make that call in src/miscops.c.

      Attachments

        For Gerrit Dashboard: PYCBC-797
        # Subject Branch Project Status CR V

        Activity

          david.kelly David Kelly added a comment - - edited

          I kept this in 3.0.0, but it won't be in LCB till 3.0.2. So depending on when that is released, we may need to put this in a later milestone. However, we only have `.future` and I'd prefer not putting it in there - by 3.0.0 time frame we will have a 3.0.1 ourselves so we can pop it in there if needed.

          david.kelly David Kelly added a comment - - edited I kept this in 3.0.0, but it won't be in LCB till 3.0.2. So depending on when that is released, we may need to put this in a later milestone. However, we only have `.future` and I'd prefer not putting it in there - by 3.0.0 time frame we will have a 3.0.1 ourselves so we can pop it in there if needed.
          Ellis.Breen Ellis Breen added a comment -

          Remove this option for 3.0.0 if present.

           

          Ellis.Breen Ellis Breen added a comment - Remove this option for 3.0.0 if present.  
          david.kelly David Kelly added a comment -

          Since LCB doesn't have a way to set this timeout, I removed from options. When the corresponding CCBC is fixed, we can just add it back in – super simple.

          david.kelly David Kelly added a comment - Since LCB doesn't have a way to set this timeout, I removed from options. When the corresponding CCBC is fixed, we can just add it back in – super simple.
          david.kelly David Kelly added a comment -

          Now that LCB supports a ping timeout, use it when specified.

          david.kelly David Kelly added a comment - Now that LCB supports a ping timeout, use it when specified.
          david.kelly David Kelly added a comment -

          CBSE-9177 would be fixed if we did this, as (at first glance, at least) the actual timeout is very short (2.5 ms).  Bumping the severity, putting in next sprint.

          Also - the timeout should default to something reasonable, like the default kv timeout, or similar.  It appears that it actually is much shorter.

          david.kelly David Kelly added a comment - CBSE-9177 would be fixed if we did this, as (at first glance, at least) the actual timeout is very short (2.5 ms).  Bumping the severity, putting in next sprint. Also - the timeout should default to something reasonable, like the default kv timeout, or similar.  It appears that it actually is much shorter.

          People

            david.kelly David Kelly
            david.kelly David Kelly
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty