Uploaded image for project: 'Couchbase Python Client Library'
  1. Couchbase Python Client Library
  2. PYCBC-831

Cluster settings like compression, tracing, etc.. should be set at Cluster initialisation only

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0-beta.3
    • 3.0.0
    • library
    • None
    • 1
    • SDK13: Coll/Txn/Docs More Chip, SDK15: Ruby/Coll/Docs

    Description

      In PYCBC-775, we added a bunch of settings to cluster which propagate down to all the buckets as well. Lets make sure when we create new buckets after a call to one or more of the setters for the various options, that bucket gets these settings as well.

      Ideally we will wait on this until we do 2 things:
      (1) share connections across collections that share the same bucket (PYCBC-815)
      (2) rework the test framework to not use the ClassicAuthenticator as this makes that cluster's subsequent open_bucket calls always fail (PYCBC-832)

      Of course, having an object that held all these settings (like an environment of some sort) is ideal. But maybe we can just cache the settings that changed in cluster, and use that to call the settings on the new bucket, etc...

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          david.kelly David Kelly added a comment -

          These settings really should be completely static – perhaps all of them should be specified in the cluster constructor (if you want non-defaults), and that is that. The set ones all should propagate to all instances created by the cluster. Lets eliminate all the setters in the Cluster and Bucket, and add some sort of dictionary where we keep track of the settings we changed, and set (via _ctrl) when we create a new instance, more or less

          david.kelly David Kelly added a comment - These settings really should be completely static – perhaps all of them should be specified in the cluster constructor (if you want non-defaults), and that is that. The set ones all should propagate to all instances created by the cluster. Lets eliminate all the setters in the Cluster and Bucket, and add some sort of dictionary where we keep track of the settings we changed, and set (via _ctrl) when we create a new instance, more or less

          People

            david.kelly David Kelly
            david.kelly David Kelly
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty