Uploaded image for project: 'Couchbase Python Client Library'
  1. Couchbase Python Client Library
  2. PYCBC-835

diagnostics hangs on any server < 6.5

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0-beta.3
    • 3.0.0
    • None
    • None
    • 1
    • SDK13: Coll/Txn/Docs More Chip

    Description

      Including the mock. For right now, I skip unless the cluster supports collections, in the tests. I think this is a something for 3.0.0 but not 3.0.0.rc, so will move on and come back to this in a bit.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          david.kelly David Kelly added a comment -

          First off – lets change that to running on any 6.5 or greater (DP or not).  Then lets fix it and get rid of that.

          david.kelly David Kelly added a comment - First off – lets change that to running on any 6.5 or greater (DP or not).  Then lets fix it and get rid of that.
          david.kelly David Kelly added a comment -

          lcb_diag immediately (synchronously) calls the callback.  We were waiting with a lcb_wait(..., LCB_WAIT_NOCHECK) which then doesn't check to see if there is anything to wait for, and just waits.  Since we are waiting on that, we hang forever.  Switching to LCB_WAIT_DEFAULT seems reasonable, if we really don't rely on LCB_WAIT_NOCHECK at all.  I'm testing that now.  If that doesn't prove problematic, great.  If it is, we can just not call lcb_wait at all for diagnostics.  

           

          What I don't understand is that this works for 6.5 and above.  Raising that with Sergey now, we will see...

          david.kelly David Kelly added a comment - lcb_diag immediately (synchronously) calls the callback.  We were waiting with a lcb_wait(..., LCB_WAIT_NOCHECK) which then doesn't check to see if there is anything to wait for, and just waits.  Since we are waiting on that , we hang forever.  Switching to LCB_WAIT_DEFAULT seems reasonable, if we really don't rely on LCB_WAIT_NOCHECK at all.  I'm testing that now.  If that doesn't prove problematic, great.  If it is, we can just not call lcb_wait at all for diagnostics.     What I don't understand is that this works for 6.5 and above.  Raising that with Sergey now, we will see...
          david.kelly David Kelly added a comment -

          https://issues.couchbase.com/browse/CCBC-1217.  Workaround is to just use LCB_WAIT_DEFAULT or not call lcb_wait at all.  I chose the former as it was a simpler changed, and seemingly did no harm.

          david.kelly David Kelly added a comment - https://issues.couchbase.com/browse/CCBC-1217 .  Workaround is to just use LCB_WAIT_DEFAULT or not call lcb_wait at all.  I chose the former as it was a simpler changed, and seemingly did no harm.

          People

            david.kelly David Kelly
            david.kelly David Kelly
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty