Uploaded image for project: 'Distributed Transactions C++'
  1. Distributed Transactions C++
  2. TXNCXX-98

Sweep through code, looking for consistency issues

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • Major
    • 1.0.0
    • None
    • None

    Description

      The git-clang-format + tidy probably do a reasonable job of making the code look consistent, however there are places (in fit performer for sure), where I've not been completely consistent.  For instance, class members having trailing vs leading underscores, stuff like that.  Lets clean that up.  

       

      While there, look for things we'd like to avoid (like, don't do the implicit conversion of a std::shared_ptr to boolean, but compare to nullptr instead).  Stuff like that.  Examine pubic interfaces, for things that could be private, etc...  

      Attachments

        For Gerrit Dashboard: TXNCXX-98
        # Subject Branch Project Status CR V

        Activity

          People

            david.kelly David Kelly (Inactive)
            david.kelly David Kelly (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty