Uploaded image for project: 'Distributed Transactions .NET'
  1. Distributed Transactions .NET
  2. TXNN-25

Rename any awaitable methods that return Task to XxxAsync

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 1.0.0-alpha1
    • None
    • None
    • 1

    Description

      AttemptContext.Commit returns a Task and is awaitable; per best practices it should post-fixed with "Async". There are a number other methods that should be renamed as well:

      1. Transactions.Run to Transactions.RunAsync
      2. AttemptContext.Insert to AttemptContext.InsertAsync, etc

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              jmorris Jeff Morris
              jmorris Jeff Morris
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty