Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-18424

ns_server watson in function names

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 4.5.0
    • 4.5.0
    • ns_server
    • Security Level: Public
    • None
    • Untriaged
    • Unknown

    Description

      Similar to MB-15614 when Sherlock was developed, the same issue has appeared with Watson.

      I think using watson as function names is going to cause future confusion, in a couple years time it won't be obvious what the following means...

       
      is_cluster_40() ->
          is_enabled([4, 0]).
       
      is_cluster_41() ->
          is_cluster_41(ns_config:latest()).
       
      is_cluster_41(Config) ->
          is_enabled(Config, [4, 1]).
       
      compat_mode_string_40() ->
          "4.0".
       
      is_version_watson(ClusterVersion) ->
          is_enabled_at(ClusterVersion, ?WATSON_VERSION_NUM).
       
      is_cluster_watson() ->
          is_enabled(?WATSON_VERSION_NUM).
      
      

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              Aliaksey Artamonau Aliaksey Artamonau (Inactive)
              ianmccloy Ian McCloy (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty