Details
Description
1.1.6 adds support for building with CMake (we built 1.1.1 on Windows by manually adding cmake build support back in the days). I've created http://review.couchbase.org/#/c/80993/ which builds the package correctly, but the python-snappy extension http://review.couchbase.org/#/c/80994/4 fails to build on Windows (http://server.jenkins.couchbase.com/job/cbdeps-platform-build/880/console) with:
22:35:23 HEAD is now at c97d633... Add __init__.py to make it as module
|
22:35:23 [ 30%] Performing update step for 'python-snappy'
|
22:35:23 [ 40%] No patch step for 'python-snappy'
|
22:35:23 [ 50%] Performing configure step for 'python-snappy'
|
22:35:23 Configuring python-snappy...
|
22:35:23 [ 60%] Performing build step for 'python-snappy'
|
22:35:23 running build
|
22:35:23 running build_py
|
22:35:23 creating build
|
22:35:23 creating build\lib.win-amd64-2.7
|
22:35:23 copying snappy.py -> build\lib.win-amd64-2.7
|
22:35:23 copying snappy_cffi.py -> build\lib.win-amd64-2.7
|
22:35:23 copying test_snappy.py -> build\lib.win-amd64-2.7
|
22:35:23 copying test_snappy_cffi.py -> build\lib.win-amd64-2.7
|
22:35:23 copying __init__.py -> build\lib.win-amd64-2.7
|
22:35:23 running build_ext
|
22:35:23 building '_snappy' extension
|
22:35:23 C:\Python27\lib\distutils\dist.py:267: UserWarning: Unknown distribution option: 'install_requires'
|
22:35:23 warnings.warn(msg)
|
22:35:23 error: Unable to find vcvarsall.bat
|
22:35:23 NMAKE : fatal error U1077: 'C:\Python27\python.EXE' : return code '0x1'
|
22:35:23 Stop.
|
22:35:23 NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
|
22:35:23 Stop.
|
22:35:23 NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
|
22:35:23 Stop.
|
22:35:23 NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
|
22:35:23 Stop.
|
22:35:23 Failed with error 2.
|
22:35:23 Build step 'Invoke XShell command' marked build as failure
|
22:35:24 FTP: Current build result is [FAILURE], not going to run.
|
Ceej was able to make a change which added the path to vcvarsall, but then it fails with a message saying it needs VC++ 9.0 to build.
Mike Wiederhold [X] - It looks like couchbase-cli is the only user of this library... is it still required, or is this functionality we could move to one of the go-tools and get rid of this extra dependency?
trond@ok:1293> find . -name "*.py" | xargs grep -i snappy | grep -v install | cut -f1 -d: | uniq
|
./couchbase-cli/cbsnappy.py
|
./couchbase-cli/pump.py
|
./couchbase-cli/pump_csv.py
|
./couchbase-cli/pump_gen.py
|
./couchbase-cli/pump_mc.py
|
./goproj/src/github.com/couchbase/indexing/secondary/bin/2ifab.py
|
(the last entry there is for a package named libsnappy-dev)
Attachments
Issue Links
- causes
-
MB-26922 2x longer rebalance with views after upgrade to Snappy v1.1.6
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
- is duplicated by
-
MB-26796 Upgrade Snappy to 1.1.6
-
- Closed
-
- relates to
-
-
- Resolved
-