Details
-
Bug
-
Resolution: Fixed
-
Critical
-
6.0.3, 6.0.4, 6.5.1, 6.6.0, 6.5.0
-
Triaged
-
1
-
Yes
Description
Problem
As described in CBSE-8828, for a replica DCP stream. If a previous item that uses XATTRs is to be deleted, however it is not resident - then we must perform a bgfetch - see MB-36087. When the bgfetch is complete we replay PassiveStream::messageReceived. However this time it fails because the last seqno now equals the sequence number of the deletion and so it is discarded.
Suggested Possible Solution
- only set the last seqno to the seqno of the message just received, once the message has been completed or
- If an EWOULD_BLOCK occurs reserve the setting of the last seqno so the message can be received again.
Attachments
Issue Links
1.
|
[BP] MB-41255 to 6.0.4 - MP2 | Resolved | Daniel Owen |
Gerrit Reviews
For Gerrit Dashboard: MB-41255 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
135539,4 | MB-41255: Don't bgfetch for a replica delete of an xattr | mad-hatter | kv_engine | Status: MERGED | +2 | +1 |
135552,1 | MB-41255: Update PassiveStream::last_seqno only on success | mad-hatter | kv_engine | Status: ABANDONED | 0 | -1 |
135746,3 | Merge branch 'couchbase/mad-hatter' into 'couchbase/master' | master | kv_engine | Status: MERGED | +2 | +1 |
135895,7 | MB-31869: Update PassiveStream::last_seqno only on success | master | kv_engine | Status: MERGED | -1 | +1 |
136003,3 | [BP] MB-41255: Don't bgfetch for a replica delete of an xattr | alice | kv_engine | Status: MERGED | +2 | +1 |
136488,2 | [BP] MB-41255: Don't bgfetch for a replica delete of an xattr | 6.5.1 | kv_engine | Status: MERGED | +2 | +1 |
136532,3 | MB-41255: Create an improve unit test that has more coverage | master | kv_engine | Status: MERGED | +2 | +1 |
137334,1 | Merge branch 'couchbase/alice' into 'couchbase/mad-hatter' | mad-hatter | kv_engine | Status: MERGED | +2 | +1 |
139594,1 | Merge commit 'couchbase/mad-hatter' into 'couchbase/master' | master | kv_engine | Status: MERGED | +2 | +1 |
140048,4 | Adding functional test for MB-41255 | master | TAF | Status: MERGED | +2 | +1 |
140102,4 | Adding functional test for MB-41255 | mad-hatter | TAF | Status: MERGED | +2 | +1 |
142433,2 | MB-41255: Merge branch '6.5.2' into mad-hatter | mad-hatter | kv_engine | Status: MERGED | +2 | +1 |
143691,1 | Merge branch mad-hatter | master | kv_engine | Status: MERGED | +2 | +1 |