Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-48094

[Magma] DCPBackfillBySeqnoDisk::markLegacyDiskSnapshot should read from snapshot version of KVStore metadata

    XMLWordPrintable

Details

    • Triaged
    • 1
    • No
    • KV-Engine Sprint 2021 August, KV-Engine-Sept-21

    Description

      MagmaKVStore methods getCollectionsManifestUid(), getCollectionsManifestUid() and getBySeqno() need to be updated to ensure they read from an on disk snapshot rather than using MagmaKVFileHandle when being used by DCPBackfillBySeqnoDisk::markLegacyDiskSnapshot( as per Ben Huddleston's comment, here and here. As it could mean that we end up reading the latest manifest uid/collection metadata rather the view of the data store that we thought we should be observing which could lead to inconsistencies when sending out legacy disksnapshot.

      This has been deferred for Cheshire-cat as magma is only DP. But must be completed for Neo.

      Attachments

        Issue Links

          has to be done before

          Improvement - An improvement or enhancement to an existing feature or task. MB-48037 Magma: support for getBySeqno

          • Major - Major loss of function.
          • Closed
          is caused by

          Bug - A problem which impairs or prevents the functions of the product. MB-47437 Legacy DCP stream from backfill getting snapshot end > highest mutation

          • Major - Major loss of function.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              richard.demellow Richard deMellow
              richard.demellow Richard deMellow
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty