Details
-
Bug
-
Resolution: Fixed
-
Major
-
master
-
Triaged
-
0
-
No
Description
The current path for DEL_VBUCKET commands hits the function EventuallyPersistentEngine::deleteVBucket which is implemented partially in KVBucket::deleteVBucket. The general path for changing a vBucket state is in KVBucket::setVBucketState however and it is easy to forget that vBuckets can change state (to dead) via the DEL_VBUCKET path when adding to the code there. Investigate implementing the DEL_VBUCKET path in terms of KVBucket::setVBucketState so that all vBucket state changes are implemented in one place in the code.
Attachments
Issue Links
- relates to
-
MB-54975 Ephemeral replica memory stats not tracked correctly when deleting replica vBucket
- Closed
For Gerrit Dashboard: MB-54976 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
196604,6 | MB-54976: Implement deleteVBucket in terms of setVBucketState_UNLOCKED | master | kv_engine | Status: MERGED | +2 | +1 |
198885,4 | MB-54976: Test that vbucket deletion closes connections | master | kv_engine | Status: MERGED | +2 | +1 |
208394,2 | MB-61465: Add unit test for deleteVbucket path | 7.2.4 | kv_engine | Status: ABANDONED | +2 | -1 |
208395,1 | [BP] MB-54976: Implement deleteVBucket in terms of setVBucketState_UNLOCKED | 7.2.4 | kv_engine | Status: ABANDONED | +2 | -1 |
208440,5 | MB-61465: [BP] Implement deleteVBucket in terms of setVBucketState_UNLOCKED | neo | kv_engine | Status: MERGED | +2 | +1 |
208441,2 | MB-61465: Add unit test for deleteVbucket path | neo | kv_engine | Status: MERGED | +2 | +1 |
208726,3 | MB-61465: [BP] Implement deleteVBucket in terms of setVBucketState_UNLOCKED | 7.2.4 | kv_engine | Status: MERGED | +2 | +1 |
208727,3 | MB-61465: [BP] Add unit test for deleteVbucket path | 7.2.4 | kv_engine | Status: MERGED | +2 | +1 |