Details
-
Task
-
Resolution: Fixed
-
Major
-
7.2.0
-
0
Description
See https://review.couchbase.org/c/kv_engine/+/186539/5/engines/ep/tests/module_tests/collections/collections_seqno_advance.cc for details.
..
|
for (const auto& e : expected.responses) {
|
auto rsp = stream->public_nextQueuedItem(
|
static_cast<DcpProducer&>(*producer));
|
// Note
|
// All the markers generated by generateExpectedResponses() are
|
// flagged by just MARKER_FLAG_MEMORY. That was correctly mirroring
|
// a bug that we fixed in MB-55465, ie we fix a case in the
|
// SeqnoAdvance code where a marker is generated with a missing CHK
|
// flag set.
|
// Problem now in this testsuite is that is more difficult to
|
// predict the marker flag that is being generated by ActiveStream.
|
// Sometimes the CHK is set, other times it's not, depending on
|
// whether the stream jumps onto new checkpoints.
|
// For that, for now we exclude SnapshotMarker in the full check.
|
// @todo MB-55535: Try to re-enable full SnapshotMarker verification
|
if (rsp) {
|
if (rsp->getEvent() == DcpResponse::Event::SnapshotMarker) {
|
EXPECT_EQ(DcpResponse::Event::SnapshotMarker,
|
e->getEvent());
|
} else {
|
EXPECT_EQ(*e, *rsp);
|
}
|
}
|
..
|
Attachments
For Gerrit Dashboard: MB-55535 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
199659,2 | MB-55535: Remove unused InputType::CPStart/CPEnd | master | kv_engine | Status: MERGED | +2 | +1 |
199662,4 | MB-55535: Fix SnapshotMarker check in CollectionsSeqnoAdvanced tests | master | kv_engine | Status: MERGED | +2 | +1 |
200039,4 | [BP] MB-55535: Remove unused InputType::CPStart/CPEnd | neo | kv_engine | Status: MERGED | +2 | +1 |
200040,4 | [BP] MB-55535: Fix SnapshotMarker check in CollectionsSeqnoAdvanced tests | neo | kv_engine | Status: MERGED | +2 | +1 |
200332,2 | Merge neo/9e1264522 into master | master | kv_engine | Status: MERGED | +2 | +1 |