Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-55535

Re-enabled SnapshotMarker full verification in the CollectionsSeqnoAdvanced testsuite

    XMLWordPrintable

Details

    • 0

    Description

      See https://review.couchbase.org/c/kv_engine/+/186539/5/engines/ep/tests/module_tests/collections/collections_seqno_advance.cc for details.

      ..
              for (const auto& e : expected.responses) {
                  auto rsp = stream->public_nextQueuedItem(
                          static_cast<DcpProducer&>(*producer));
                  // Note
                  // All the markers generated by generateExpectedResponses() are
                  // flagged by just MARKER_FLAG_MEMORY. That was correctly mirroring
                  // a bug that we fixed in MB-55465, ie we fix a case in the
                  // SeqnoAdvance code where a marker is generated with a missing CHK
                  // flag set.
                  // Problem now in this testsuite is that is more difficult to
                  // predict the marker flag that is being generated by ActiveStream.
                  // Sometimes the CHK is set, other times it's not, depending on
                  // whether the stream jumps onto new checkpoints.
                  // For that, for now we exclude SnapshotMarker in the full check.
                  // @todo MB-55535: Try to re-enable full SnapshotMarker verification
                  if (rsp) {
                      if (rsp->getEvent() == DcpResponse::Event::SnapshotMarker) {
                          EXPECT_EQ(DcpResponse::Event::SnapshotMarker,
                                    e->getEvent());
                      } else {
                          EXPECT_EQ(*e, *rsp);
                      }
                  }
      ..
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            paolo.cocchi Paolo Cocchi
            paolo.cocchi Paolo Cocchi
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty