Uploaded image for project: 'Scala Couchbase Client'
  1. Scala Couchbase Client
  2. SCBC-270

Collection manager not parsing errors correctly

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.0.10
    • 1.2.0
    • 1
    • SDK28: Docs/Test/Release

    Description

      There are a number of errors that have changed their error message response from the server and therefore the errors are not being parsed correctly here: https://github.com/couchbase/couchbase-jvm-clients/blob/44d009ffc2c3920d516a2ae1345132f4a86946b7/scala-client/src/main/scala/com/couchbase/client/scala/manager/collection/ReactiveCollectionManager.scala#L214

      (Same issue as in JCBC-1728, but bug not in shared code)

      Here's a list of the current (7.0.0-3507) error responses:

      Scope already exists:
      {"errors":{"_":"Scope with name \"2d33a596-8\" already exists"}}

      Collection already exists:
      {"errors":{"_":"Collection with name \"b185d9f9-0\" in scope \"7df92294-3\" already exists"}}

      Scope not found:
      {"errors":{"_":"Unknown error {error,{scope_not_found,\"foobar\"}}"}}

      Collection not found
      {"errors":{"_":"Unknown error {error,{collection_not_found,\"a9e4f276-3\",\"1141f1d0-b\"}}"}}

       

      There are a number of test failures related to this: http://sdk.jenkins.couchbase.com/view/Nightly/job/jvm/job/jvm-clients/job/couchbase-jvm-clients-scipted-build-pipeline/533/testReport/com.couchbase.client.scala.manager/CollectionManagerSpec/

       

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Hey Graham, this came up in the QE meetings. Could you please let me know if you can work on this fix?

            pablo.silberkasten Pablo Silberkasten (Inactive) added a comment - Hey Graham, this came up in the QE meetings. Could you please let me know if you can work on this fix?
            graham.pople Graham Pople added a comment -

            Sorry, this one slipped through the cracks due to competing priorities.  I'll try to get it done for the next release.

            graham.pople Graham Pople added a comment - Sorry, this one slipped through the cracks due to competing priorities.  I'll try to get it done for the next release.

            Thanks Graham!

            Were you able to check at this one https://issues.couchbase.com/browse/SCBC-259 as well?

            Thanks!

            pablo.silberkasten Pablo Silberkasten (Inactive) added a comment - Thanks Graham! Were you able to check at this one https://issues.couchbase.com/browse/SCBC-259  as well? Thanks!
            graham.pople Graham Pople added a comment -

            Reviewing the code now and most of them have already been addressed in JCBC-1792 and SCBC-271.  collection_not_found has not, but I am testing with build 5274 and it is returning `{"errors":{"_":"Collection with name \"does_not_exist\" in scope \"288625c7-a\" is not found"}}` when attempting to drop a collection, so the existing code is working.  For safety I will add just-in-case handling for collection_not_found also.

            graham.pople Graham Pople added a comment - Reviewing the code now and most of them have already been addressed in JCBC-1792 and SCBC-271 .  collection_not_found has not, but I am testing with build 5274 and it is returning `{"errors":{"_":"Collection with name \"does_not_exist\" in scope \"288625c7-a\" is not found"}}` when attempting to drop a collection, so the existing code is working.  For safety I will add just-in-case handling for collection_not_found also.

            People

              graham.pople Graham Pople
              will.broadbelt Will Broadbelt
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty