Details
-
Task
-
Resolution: Fixed
-
Major
-
Cheshire-Cat
-
None
-
1
-
KV-Engine Sprint 2021 August, KV-Engine-Sept-21
Description
We attempted to upgrade Snappy from 1.1.1 to 1.1.6 via MB-25339, as part of Vulcan. However this "upgraded" version resulted in various performance regressions (MB-26922, MB-26923, MB-26924), even though Snappy's own published numbers and our own micro-benchmarking runs the newer version was faster (up to 20% faster decompress, 5% faster compress; see https://github.com/google/snappy/releases/tag/1.1.4).
KV-Engine continues to spend a significant amount of time in snappy (de)compression; moreso for high DGM workloads (all data on-disk is Snappy-compressed), so it would be advantageous if we could take advantage of the performance improvements which should be available in newer versions. However we first need to understand why the last upgrade regressed.
Attachments
Issue Links
- relates to
-
MB-25339 Upgrade snappy from 1.1.1 to 1.1.6 (includes build support via CMake)
- Closed
For Gerrit Dashboard: MB-43620 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
154742,1 | MB-43620: wip | master | kv_engine | Status: NEW | 0 | -1 |
154679,1 | MB-43620: snappy 1.1.6 | master | tlm | Status: ABANDONED | 0 | -1 |
155803,21 | MB-43620: Upgrade to Snappy 1.1.8 | master | tlm | Status: MERGED | +2 | +1 |
155805,20 | MB-43620: Use Snappy 1.1.8 | master | tlm | Status: MERGED | +2 | +1 |
159995,2 | MB-43620: toy-daver-neo: Use snappy 1.1.8 | master | manifest | Status: MERGED | +2 | +1 |
160888,3 | MB-43620: Install snappy libs in bin/ on Windows | master | tlm | Status: MERGED | +2 | +1 |
160914,2 | MB-43620: Update BD manifest for snappy 1.1.8 | master | tlm | Status: MERGED | +2 | +1 |
160929,2 | MB-43620: Revert to snappy 1.1.1 for Windows | master | tlm | Status: MERGED | +2 | +1 |
160989,4 | MB-43620: Still need to report snappy 1.1.1 on Black Duck | master | tlm | Status: MERGED | +2 | +1 |
161098,5 | MB-43620: Snappy: disable BMI2 instructions | master | tlm | Status: MERGED | +2 | +1 |